Skip to content

test: add tests for recommended rules #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025
Merged

test: add tests for recommended rules #236

merged 1 commit into from
Aug 11, 2025

Conversation

fasttime
Copy link
Member

@fasttime fasttime commented Aug 10, 2025

Prerequisites checklist

What is the purpose of this pull request?

Add unit tests

What changes did you make? (Give an overview)

Added a unit test to verify that the recommended config configures exactly the rules marked as recommended. This ensures that the autogenerated file src/build/recommended-config.js works as expected.

Related Issues

eslint/json#134, eslint/markdown#503

Is there anything you'd like reviewers to focus on?

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snitin315 snitin315 added the accepted There is consensus among the team that this change meets the criteria for inclusion label Aug 11, 2025
@snitin315 snitin315 merged commit cb52606 into main Aug 11, 2025
22 checks passed
@snitin315 snitin315 deleted the test-rules branch August 11, 2025 04:48
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion chore
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants